Skip to content

fix: add option to write body facets to explicit export methods #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

fix: add option to write body facets to explicit export methods #2231

wants to merge 20 commits into from
+52 −8

Conversation

@jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Sep 16, 2025

Description

these export methods were originally missed when adding this parameter

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Sep 16, 2025
@jonahrb jonahrb requested a review from a team as a code owner September 16, 2025 14:45
@github-actions github-actions bot added the bug Something isn't working label Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (d213085) to head (90dcf93).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
+ Coverage   95.35%   95.37%   +0.01%     
==========================================
  Files         168      168              
  Lines       11094    11094              
==========================================
+ Hits        10579    10581       +2     
+ Misses        515      513       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the testing Anything related to tests label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jonahrb jonahrb

Labels

bug Something isn't working testing Anything related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonahrb @RobPasMue @pyansys-ci-bot @syscordan